Shane F. Carr

Results 1856 comments of Shane F. Carr

To-do: Take a birds-eye view of our errors before 1.0.

Discussion: - @zbraniecki - Do you mean something like this? ``` enum ICUError { DataProvider(), Consistency(), InvalidInput(), UnexpectedError(), } impl Into for DateTimeFormatError {} ... right? ``` - @zbraniecki -...

### How to represent sign display in FixedDecimal? Currently, FixedDecimal has a boolean field "is_negative". This should change to an enum `Sign` with three possible values: Positive, Negative, and None....

I think what I'm trying to achieve with `FixedDecimal` and `FixedDecimalFormat` is to make `FixedDecimalFormat` as thin as possible, and focused on exclusively display concerns. The definition of "display concerns"...

CC @echeran. I added you to the approvers list.

We need to define *exactly what is a FixedDecimal* and what is its lifecycle. My mental model has been that a FixedDecimal is a ***locale-agnostic, structured representation of the human-readable...

Discussion with @eggrobin and others: - We should have a method to support a strict SampleValue syntax parsing for FixedDecimal - The other syntax, `#.#E#`, is common in the wild...

For the purposes of 1.0, I think we should focus on landing the updated `FixedDecimal` (with the change to sign-display). `CompactDecimal` and `ScientificDecimal` can come soon after, in 1.1.

@eggrobin Is there anything left on this ticket?

We do want the CI job to cache the downloaded CLDR and ICU data, which I think is why we wrote it separately