Shane F. Carr

Results 1850 comments of Shane F. Carr

@sffc to document that the string parsing APIs may be replaced in the future.

The string parsing APIs can be found here https://unicode-org.github.io/icu4x-docs/doc/icu_datetime/mock/index.html

- @sffc - These functions are bad because they are not correct for parsing ISO strings. There are valid ISO strings that people can pass to these functions which will...

Discussion: - @echeran - Not everything has a locale, but everything has a provider, so maybe the provider should go first - @Manishearth - Generally more specific arguments should go...

Discussion with @sffc @Manishearth: - @Manishearth - An advantage of transparent options is that Diplomat can create better APIs. A disadvantage of opaque is that we need to allocate, but...

It appears that #1833 still has unresolved questions. In light of that, let me be clear on what I am proposing for constructor signatures in ICU4X 1.0. In Rust: ```rust...

I should also note a potential path for Rust constructors involving traits ``` trait TryNewBufferProvider { fn try_new(locale: DataLocale, p: &impl BufferProvider, options: O) } impl TryFromBufferProvider for FooFormat {...

- @robertbastian - If we take DataLocale in our APIs, why do we have Locale? - @robertbastian - Can we collapse the constructors for and/or/unit into a single buffer or...

- @robertbastian - Should we take the locale by value? - @sffc - I prefer by reference and cloning only when we need to, when loading data. - @robertbastian -...

Consensus: No objection to what I proposed in https://github.com/unicode-org/icu4x/issues/2136#issuecomment-1183797247.