Shane F. Carr

Results 1847 comments of Shane F. Carr

To summarize my takeaways from a discussion on this topic with @robertbastian: - We both agree that eventually the constructor type, which I'll call `Preferences`, should be different than the...

@sffc to investigate potential internal improvements here.

@robertbastian will clean up low-hanging fruit, and create child issues for each component

@zbraniecki Assigning this to you since the remaining work is all in components you own.

@zbraniecki I've raised that concern before (also for `expect`) but the consensus of the group has been to require suppressions for all four (unwrap, expect, panic, and indexing_slicing).

For example, the following is the style we're going for: the comment and the panic message are disjoint ```rust /// # Panics /// Panics if idx is not in bounds...

The regions using non-Gregorian default are: - AF, IR (persian) - SA (islamic-umalqura) - TH (buddhist) Source: https://github.com/unicode-org/cldr/blob/b2b36963947b0e3e172fa40519d13afd9877a227/common/supplemental/supplementalData.xml#L4715 Of those, the only one we support right now is Buddhist. So...

Created #2236 for the longer-term solution to this problem.

@makotokato Can you work on this, after the other 1.0 issues are done?

Segmenter is going to remain in alpha at ICU4X 1.0 so I'm moving this to 1.1