Shane F. Carr

Results 1850 comments of Shane F. Carr

I reviewed all component and property APIs. To-do list: - [x] AnyCalendar: make `&provider` the first argument - [x] Japanese and JapaneseExtended: add Any/Buffer - [x] JapaneseEraStyle: see if enum...

For FFI purposes, it would make things a lot simpler if we had just one provider type. It would be an enum between a buffer provider and an any provider....

None of our choices are ideal: 1. Enum toggling between Buffer and Any with a feature on icu_capi to enable/disable Buffer mode 2. Add two versions of all the constructors...

- @robertbastian - How should someone give their own BakedProvider over FFI? Maybe datagen could output something to help. - @Manishearth - That sounds workable with some asterisks. Or people...

Action: @sffc to document this.

> ...which comes with additional deserialization overhead I'd like to clarify this in the sense that there is no additional overhead relative to if you are already using a BufferProvider...

How about this: ``` foo_unstable /// ... main docs ... /// /// # Stability /// /// The bounds of this function may not remain stable across minor releases. [Details](icu_provider) ///...

This is excellent feedback. I'll work on a PR to address the pain points you found.