Shane F. Carr

Results 1724 comments of Shane F. Carr
trafficstars

For the properties types, my `Default` solution won't work, because there is not a single constructor for those types. So we should probably come up with a general solution that...

Here's another question. In 2.0, should the types be named `Foo` and `FooBorrowed`, or should they be named `FooOwned` (or `FooData`) and `Foo`?

Collator is the main example of a type that would be locale-dependent but might benefit from a Borrowed version. We can make databake capable of returning the right thing even...

@robertbastian prefers keeping the four constructors together in the docs. @robertbastian therefore prefers: ```rust // Always: Foo::new() -> FooBorrowed

One thing @robertbastian said which I agree with is that `Foo::new() -> Foo` is a bad function because it unnecessarily wraps the static ref in the enum (DataPayload) which leads...

I think the intent with 2 is that we create the function in code at the same time as we create the feature that gates the owned type, and otherwise...

I don't think there's generally a way to make `Owned` everywhere, even on non-singleton types, but not in 2.0 because that is a really big change. A middle ground would...

Observation: if we have `Foo::new() -> Foo` and then we migrate `Foo` to have a borrowed variant, we won't be able to change the function signature in 2.x. We'd need...

I don't see a clear consensus on this thread and it seems we are not on the same page so I tagged it with discuss-priority