sedefsavas
sedefsavas
Reminder: Create issue for dual-stack and replicate this for EKS
/priority important-soon
We might want to address IPv6 and dual stack as separate problems as former could be achieved in short term.
/assign @richardcase For triage.
After creating a cluster with `kind create cluster` before `tilt up`, you should be able to see the pods. https://kind.sigs.k8s.io/docs/user/quick-start/#creating-a-cluster You might have an old kubeconfig path set to the...
TODO: Remove the KIAM documents and point to Multi-tenancy instead. Could be done together with https://github.com/kubernetes-sigs/cluster-api-provider-aws/issues/2105
We need to convert existing subnets in the ASG (`VPCZoneIdentifier`) to `AutoScalingGroup.Subnets` using SDKToAutoScalingGroup() method, it is missing right now. VPCZoneIdentifier is a comma separated list.
SDKToAutoScalingGroup() should not need to be called from [awsmachinepool_controller.go](https://github.com/kubernetes-sigs/cluster-api-provider-aws/blob/6ab95625da2aabb209bc5744883eb4c009cc4fba/exp/controllers/awsmachinepool_controller.go#L534) **1) Changes that will be done in SDKToAutoScalingGroup() method:** add Subnets field to the conversion: ``` i := &expinfrav1.AutoScalingGroup{ Subnets: create_slice_from_comma_separated_subnets(v.VPCZoneIdentifier)...
I don't see where the javascript bits are but tested and looks good. /lgtm