sedefsavas

The script was using the same variable names with Makefile before and I changed them because they were getting overridden: https://github.com/kubernetes-sigs/cluster-api-provider-aws/pull/3388 Can you confirm that this issue does not get...

Any updates? /remove-lifecycle stale

Sticking with the camel case test naming convention is another option here. Core Cluster API is following that and few other providers as well. If there are places we don’t...

Hi @akash-gautam, thanks for the PR. Few considerations here: 1- What would be the benefit of using MachinePool Machines for graceful shutdowns like CAPZ? 2- Can this implementation be extended...

How about graduating eventbridge experimental feature and repurpose it to get event notifications for ASG scale in as well? This will be also useful when we want to implement spot...

Created an issue for the eventbridge graduation https://github.com/kubernetes-sigs/cluster-api-provider-aws/issues/3414

This LGTM. I created an AMI named `custom-amazon-2-1.24.1-build.0-1655360804`, it'd be good to add an e2e test for this. Let me know if I need to change the name. Also, would...

Btw the image is in `us-west-1`.

ACK, we can go over it in the office hours if needed.

As a side note, we allow users to specify their own subnets not only in `clusterNetwork` but also in `controlPlaneLoadbalancer.subnets`. I noticed that we only tag the machine subnets when...