Sean Doyle

Results 89 comments of Sean Doyle

@iansan5653 that's reasonable! How do you feel about opting-into each key individually? ```typescript type OptionalNavigationKeys = "Home" | "End" // ... optionalNavigationKeys: OptionalNavigationKeys[] ```

Do you have an idea for what the constructor argument name should be? Is a third positional Boolean argument sufficient, or is it time to accept a third argument as...

Unfortunately, https://github.com/rails/rails/pull/41291 was closed due to inactivity, and as a result, the context for this discussion must be split between two pull requests. Due to that split, I need to...

@rafaelfranca thank you for jumping back into this conversation! I'm sorry for the long pause and the change in venue. > Why would someone chose this new list of assertions...

Thank you two for your perspectives. While I'm personally interested in exploring ways to optimize Capybara, I'm curious about the viability of this Pull Request in its current form. The...

> is that a frequent pattern in a context I'm unfamiliar with? The use case that got me digging was inline editing: ```erb Edit ``` Rendering the partial with a...

@croaky Also, I'm not sure how we've gone about communicating dependency removals in the past, but we'd probably want to point users to the docs for `TimeHelpers` (probably in the...

@calebthompson `freeze` could be replaced by [travel_to](https://github.com/rails/rails/blob/a6f55fe257512731d7f3f41976648d99e9ec95be/activesupport/lib/active_support/testing/time_helpers.rb#L89-L106) with a `block` couldn't it?

@croaky good to merge and bump the release? Should we ask for more opinions?

Apparently the two behave differently. `Timecop.freeze` sets `Time.now` to the given time _and_ stops the flow of time within the block. `travel_to` _only_ sets `Time.now` to the given time. Time...