Sean Doyle

Results 89 comments of Sean Doyle

https://github.com/rails/rails/pull/45606 has been merged, and will likely be part of the 7.1 release. Along with that change, what else can be done?

@dorianmariefr I've opened https://github.com/thoughtbot/factory_bot_rails/pull/427 to attempt to add support for `file_fixture` to Factories.

@carlosantoniodasilva could you approve the CI workflow for this PR?

Thank you for catching that @stevepolitodesign! Are you interested in opening a PR to remove that line in the short term? If not, I'm happy to open one.

I've opened https://github.com/bigskysoftware/idiomorph/pull/49 to try and resolve this issue.

> Unless I'm missing a use case, I'd suggest removing `exclude_ember_deps` from ember-cli-rails. I'm in favor of this. I'll investigate when I have some free cycles (PRs welcome!).

@littleforest the asset changes merged as part of https://github.com/thoughtbot/administrate/pull/2397 have introduced merge conflicts. If you're interested, I'm willing to give resolving those conflicts a try and force-pushing to this branch....

The motivation behind proposing these changes was to start the conversation about deprecating the public interface around UJS so that Action View could shed some of its maintenance burden. I'm...

@rafaelfranca I've reduced the scope of this diff since the last time you've reviewed it. Originally, the PR was a little too ambitious, and involved both issuing deprecation warnings as...