Sean Doyle

Results 89 comments of Sean Doyle

Sharing a reminder here: Should this change also include support for passing options like `:remote`, `:method`, `:url`, `:params`, etc. to [link_to](https://github.com/rails/rails/blob/c80fa6a0697656a522b7688d116a9a6fca1fc0fd/actionview/lib/action_view/helpers/url_helper.rb#L234-L244)? I think it should, since `link_to` **does not** integrate...

The migration path forward for upgrading applications that want to retain UJS is fairly clear: 1. replace `remote: true` with `data: { remote: true }` 2. remove `remote: false` 3....

@rafaelfranca @eileencodes I've reconsidered the initial proposal implemented by https://github.com/rails/rails/pull/43361/commits/e428beb1ed1301183c0d8ef52e6b4b72ecce02de. In its place, [c571a1f](https://github.com/rails/rails/pull/43361/commits/c571a1f6348591092315f672bbca646159c4d445) introduces a `config.FRAMEWORK.assertions` configuration value to control the assertions used by `ActionController::TestCase`, `ActionDispatch::IntegrationTest`, and `ActionView::TestCase`. I've...

@matthewd I'm sorry to have let this PR drift so far behind `main`. I've rebased it. To re-iterate my main motivation for this change: I think my surprise stems from...

@matthewd I've expanded this work to include a new `config.action_view.renders_void_form_elements` configuration value and 7.2 default. Does that level on granular control improve this change's backwards compatibility? I'm hopeful that it...

@rafaelfranca could you review these changes?

@skipkayhil are you able to review this proposal?

@stanhu I've pushed up changes to resolve the Rubocop violations.

I've rebased this change and caught up to the latest `main`. @keithamus Thank you for granting me CI permissions! Is this change something the team is interested in supporting?

@rafaelfranca thank you so much for your detailed review, especially the benchmark. I would love to address these performance issues enough to make my recent batch of TagBuilder pull requests...