Adrian Sampson

Results 1031 comments of Adrian Sampson
trafficstars

Maybe I've missed the broader point here, but it seems like the original problem points to some pretty low-hanging fruit for a static checker (i.e., something for the paper-cut pass):...

Thanks! We should probably catch `OSError` in that check.

Oh, also: can you please include details about your system setup (OS, Python version, etc.)?

Awesome, yes, this seems great to have, especially if you have a nonstandard place where you want to keep your configuration file. Please do open a PR if you get...

This all sounds great! Thanks for the extra elaboration. I like the idea of just being able to pass a list, which would be equivalent to getting the `add` and...

Hmm; thanks for pointing this out. Here's a short little script to demonstrate the problem: ```py import confuse config = confuse.Configuration('foo') config.add({ 'import_write': 'qux' }) print(config['import_write'].get(confuse.OneOf(['ask', 'skip']))) ``` Looking at...

Hi! Here's that `load_yaml` function that shows up in your traceback: https://github.com/beetbox/confuse/blob/04036148cfa394b951cde64f4627f214f1c4e659/confuse/yaml_util.py#L85-L86 We are in fact closing the file after reading it. You mentioned that you are running this program...

Cool! Yes, this seems like a good argument in favor of the way Confuse merges configuration sources. Your way doesn’t look bad at all. But there is a `set_file` method...

Quite true! We would love help getting that documentation started if anyone has time to open a PR.

Thanks, @lalinsky! I'm going to reopen this issue as a reminder that we should add an earlier type check to make it clear what's gone wrong when this happens.