sagudev

Results 348 comments of sagudev
trafficstars

Maybe instead of querying real fs in unit test, virtual fs can be constructed instead at the start of test. Also having test files in `tests/wpt` seems weird (as these...

Yeah, I looked again and it seems that all require wrapper for fs functions. But there are crates for tmp directories, so those can be used and manually populated at...

One thing to note is that clippy is a rustc driver. When you run cargo clippy what actually happens is that cargo check is run with additional lints provided by...

Also given that there was quite some PRs that introduced warnings and then fixup PRs that fixed them, I think we should make them fail CI (at least for rustc...

I have [GitHub Actions](https://marketplace.visualstudio.com/items?itemName=GitHub.vscode-github-actions) extension in VSCode, but that is just for syntax. I am not aware of any faster way.

> What does it mean for an object to be "JS managed?" That it needs to be GCed. > Why do some objects implement JSTraceable , but have no-op implementations?...

Another alternative is something like this: https://play.rust-lang.org/?version=stable&mode=debug&edition=2021&gist=9fa68d01e0dc08f3e24997fd3b31d46d. This code could be generated in proc-macro of JSTraceable, so `no_trace` and nop tracers would no longer be necessary and JSTraceable would only...

> So do I understand this correct that a "JS managed" object is one that needs to be garbage collected, but a JSTraceable object is one that has children that...

> Hrm. So these traits are essentially: `NeedsToBeGarbageCollected` and `HasGarbageCollectedFields`? Well JSManaged types are for both, while JSTraceable are just types that implements JSTraceable even if they are not GCed.