sagudev

Results 348 comments of sagudev
trafficstars

CRASH [expected OK] /_webgl/conformance/more/functions/texImage2DBadArgs.html CRASH [expected OK] /_webgl/conformance/textures/misc/gl-teximage.html This could be due to LLVM bump in rust.

`_webgl/conformance/more/functions/texImage2DBadArgs.html`: ``` unsafe precondition(s) violated: ptr::copy_nonoverlapping requires that both pointer arguments are aligned and non-null and the specified memory ranges do not overlap (thread Script(1,1), at library/core/src/panicking.rs:156) 0:02.48 pid:62526 0:...

> ``` > │ unsafe precondition(s) violated: ptr::copy_nonoverlapping requires that both pointer arguments are aligned and non-null and the specified memory ranges do not overlap (thread Script(1,1), at library/core/src/panicking.rs:156) >...

Apparently destination pointer is null although it shouldn't be as this was checked upon it's creation: https://github.com/sagudev/ipc-channel/blob/4c01b78a108d761ac67407da1359b8293c7c93ef/src/platform/unix/mod.rs#L803

> Note that even if the effectively copied size (count * size_of::()) is 0, the pointers must be non-null and properly aligned.

Related: https://github.com/servo/ipc-channel/issues/268

Testing https://github.com/servo/ipc-channel/pull/335

I guess there are even more debug assert failures, this time unrelated to ipc-channel. (I somehow knew, that it was to good to be true for whole repo to be...

TODO: Do fixme from https://github.com/servo/servo/pull/32262.

> @sagudev Is [servo/ipc-channel#335](https://github.com/servo/ipc-channel/pull/335) the last thing that is blocking the Rust 1.78 upgrade, or are there any other failures? https://github.com/servo/ipc-channel/pull/335 is the only blocker (we also need to release...