sagudev

Results 368 comments of sagudev

Oh, you're right, I also completely missed `best represetation of the number n as a floating point number` part. ECMAScript parsing of floats is implemented in SM (I think), so...

Timings are more sane now (we actually outperform firefox on [onSubmittedWorkDone tests](https://gpuweb.github.io/cts/standalone/?q=webgpu:api,operation,onSubmittedWorkDone:*) due to https://bugzilla.mozilla.org/show_bug.cgi?id=1870699): ![Servo run onSubmittedWorkDone tests in 350ms](https://github.com/servo/servo/assets/16504129/f0895afa-4b97-40f0-9e95-0f515620eabd) ![Firefox run onSubmittedWorkDone tests in 101535.0 ms = 1.7...

We are still missing poll somewhere because `webgpu:api,operation,compute,basic:large_dispatch:*` has flaky TIMEOUT (unless we poll every loop iteration, this could also be locking race in wgpu).

I think there might be deadlock between poll and submit EDIT: They are: https://github.com/gfx-rs/wgpu/issues/5687

Some flakes that do occur but rarely (sometimes they are stable, other times they simply do not happen): - `CRASH [expected OK] /_webgpu/webgpu/cts.https.html?q=webgpu:api,validation,buffer,mapping:mapAsync,state,destroyed:*` with: ``` called `Result::unwrap()` on an `Err`...

> > (this is actually our fault as we do not handle this situation). > > File an issue for this one? Seems like we can catch the destroy error...

Assert line in surfman: https://github.com/servo/surfman/blob/0825ee68a77df1a0720763b7006b500a52ec36e4/surfman/src/platform/generic/egl/surface.rs#L179 It appears that EGL returns no surface. Might be that there are some deps still missing. Did you run `mach bootstrap`?

The only problem that I have now is updating this in nix, we need to wait for https://github.com/oxalica/rust-overlay/tree/master to get new version.

@mrobinson land it, if it is OK.