sagudev

Results 349 comments of sagudev
trafficstars

Somehow related, I use https://github.com/servo/servo/commit/4a8ef8bd5d1fb52dc37b6216d04de09aceea9568 for webgpu runs to make output shorter to actually get results (webgpu test are very very verbose)

Cleanup usually goes something like this in firefox: ``` if (!bridge) { return; } if (bridge->CanSend()) { bridge->SendBufferDrop(mId); } wgpu_client_free_buffer_id(bridge->GetClient(), mId); ``` so we can probably move id freeing to...

Could you try linux artifact from: https://github.com/servo/servo/actions/runs/8952142892

> Solved by the PR? No, this still something that needs to be done.

I think parallelization feature on cc only works if you use .compile() method, but we use manual invocation for building windows dlls: https://github.com/servo/mozangle/blob/0b63127ca500e07198d9da3a28495d393992c3d5/build.rs#L109 Ultimately, I think we should just use...

If we can somehow make perfs to take effect in compile time as opt-in (so they would still work in runtime, but if you disable them in compile time you...

We got handful of FAIL instead of PASS: https://github.com/sagudev/servo/actions/runs/9148458722/job/25151468770, but I believe those where fake passes.

> Overall it looks good to me, but I wonder if we need the `WebGPURequest::DispatchError`, because it seems to me that those errors are always dispatched from the device timeline....

Given that all [gpu errors](https://www.w3.org/TR/webgpu/#gpuerror) are sent to script thread, we could just send poperrorscope to script thread to so it gets picked up from `handle_msg_from_webgpu_server` after all validation errors...

> validation errors from script thread (we can always just add new msg for it, but are they even needed as all validation should (but currently does not) happen in...