sagudev

Results 367 comments of sagudev

The codegen one might require more changes (maybe check usages of `str_to_const_array`). When dealing with codegen I usually check generated files, to see what's wrong.

> Are there tests for codegenRust? No. > And/or should there be? Probably, but I do not expect you write them.

I think we can generalize this a bit more (adding optional custom error message using format syntax) and move it to ipc channel as similar pattern is everywhere not just...

> I suspect that different modules will want to handle IPC failures in different ways. For instance in the case of WebGPU, it will likely need to shut down the...

> > should I do it part of this PR? > > If it's possible to write a macro to halt execution of the current function, trigger the shutdown of...

> > > > should I do it part of this PR? > > > > > > > > > If it's possible to write a macro to halt...

> > They are cleaned when Drop of associated dom objects is called (dropping GPUBuffer will send `DropBuffer` to wgpu thread), although if the thread is dead (that's probably the...

IIUC taffy also depends on stylo, so this might make stylo bumps even harder, right?

Ah, I was fooled by `taffy_stylo`. Thanks for explanation.

Like jschwe said, that warning is intended, but we could rename it to make it sound less scary.