sagudev

Results 349 comments of sagudev
trafficstars

``` error[E0308]: mismatched types --> components/fonts/tests/font_context.rs:167:19 | 167 | list: names.into_boxed_slice(), | ^^^^^^^^^^^^^^^^^^^^^^^^ expected `ArcSlice`, found `Box` | = note: expected struct `ArcSlice` found struct `std::boxed::Box` ```

`self.constructor` is only available in python, rust cannot use python's variables.

There were some changes to how importing is done. All you need to to is add proper use statements to `import.rs`. https://github.com/servo/servo/pull/31569 was made before this was introduced in https://github.com/servo/servo/pull/31711.

I am not sure if I understand error, it better to use \``` blocks when having code of multiple lines. From what I see in PR you need to be...

you can pass `isHTMLConstructor` as bool arg to function or use generic constants like it was done in https://github.com/servo/servo/commit/68f4b359c53b241e0ef82b640e84d8de70cfb805#diff-501f82b025ccf77a47ba693a8e1e56bacd4629b134c6206271de0dea1f857505L1983

I think this is related to https://github.com/servo/servo/issues/32816. Getter and methods should work as expected, after it's resolved, but I haven't touched the callbacks.

related without any special setting (happens in CI on `url/failure.html`): ``` 0:08.22 pid:552005 Full command: /home/user/Desktop/servo/target/release/servo --hard-fail -u Servo/wptrunner --ignore-certificate-errors http://web-platform.test:8000/url/failure.html -Z replace-surrogates --user-stylesheet /home/user/Desktop/servo/resources/ahem.css --certificate-path /home/user/Desktop/servo/tests/wpt/tests/tools/certs/cacert.pem pid:552005 already mutably...

Back traces of all threads: ``` bt all thread #1 frame #0: 0x00007ff873a13b94 ntdll.dll`NtWaitForAlertByThreadId + 20 frame #1: 0x00007ff8739a3eb5 ntdll.dll`TpWorkOnBehalfClearTicket + 149 frame #2: 0x00007ff8739bfeac ntdll.dll`RtlDllShutdownInProgress + 652 frame #3:...

if we delay dropping of ipc stuff the panic does not happen: ```patch diff --git a/components/net/tests/resource_thread.rs b/components/net/tests/resource_thread.rs index 9a32143d71..c52884b243 100644 --- a/components/net/tests/resource_thread.rs +++ b/components/net/tests/resource_thread.rs @@ -35,6 +35,7 @@ fn test_exit()...

I think it's at https://github.com/servo/ipc-channel/blob/24eee8a73885c97edae0b13598e115b0a356f999/src/platform/windows/mod.rs#L1686