sagudev

Results 367 comments of sagudev

data clone errors are due to hacks in principals.rs

> Only one last test result to investigate! > > ``` > ▶ OK [expected CRASH] /dom/nodes/insertion-removing-steps/blur-event.window.html > │ ▶ FAIL [expected PASS] element does not fire blur event upon...

> ShouldNotImplDomObject assertions are broken I guess the problem here is that we do this check using trait shenanigans and orphan rules bit us hard, but we can port inheritance_integrity...

> open WebGLRenderingContext.webidl and add a new undefined whatever();, then add fn Whatever(&self) {} to the corresponding impl in webglrenderingcontext.rs, then build ```patch diff --git a/components/script/dom/webglrenderingcontext.rs b/components/script/dom/webglrenderingcontext.rs index 51bde8adeb..555ffc333a 100644...

Ubuntu 24.04, AMD Ryzen 7 PRO 5875U (16 threads, 8 cores), 16GB RAM (laptop) I also unset `CCACHE` that I usually use. # Debug | | main | branch |------------|---------|---------...

> This seems like a great change. I am wondering if it would be possible to get further benefits (both compile time speed ups, and modularity) by splitting the script...

> I'm planning to move ahead with this work, following the path I outlined in the initial PR description to reduce the risk of rebase conflicts and making overall changes...

I tried to extract problem with `DecodeSuccessCallback` that uses `allow_unrooted_interior` but this doesn't compile (although similar code compiles in servo): ```rust #[crown::unrooted_must_root_lint::allow_unrooted_interior] struct Outer { inner: Inner2, } #[crown::unrooted_must_root_lint::must_root] struct...

We have https://github.com/servo/servo/blob/c7a4e4f627f0bf331cedc1700ddeb92ffcba4e78/components/script/dom/bindings/mod.rs#L172-L175