sagudev

Results 349 comments of sagudev

No, it's https://github.com/servo/ipc-channel/blob/24eee8a73885c97edae0b13598e115b0a356f999/src/platform/windows/mod.rs#L1689 (based on bt posted above).

Works on my windows (11) machine. Make sure you have accurate time/date on your computer.

Thanks for the clarification. We need to use ttps://github.com/rustls/rustls-native-certs, then create pref to force? use system certs: https://github.com/servo/servo/blob/b4e1ec441254daf2df75f84347480a9afb9f4779/components/net/connector.rs#L183. We currently do support loading custom certs, but they need to be...

> [no way](https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/evaluate-expressions-in-workflows-and-actions) to check the status of another job in an if condition I think this can be done as a step that obtains that using REST and then...

Also do note that there are [workflow call nesting limits](https://docs.github.com/en/actions/sharing-automations/reusing-workflows#nesting-reusable-workflows).

> [prepending a separate “decision job”](https://stackoverflow.com/a/78063038) to select the runner for a job would be [inherently racy](https://en.wikipedia.org/wiki/Time-of-check_to_time-of-use) Can't we use [job concurrency](https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/control-the-concurrency-of-workflows-and-jobs) for this?

I will do more thoroughly review by Monday.

Maybe instead of checking for any cancelled job we can only check if workflow is canceled: https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/evaluate-expressions-in-workflows-and-actions#cancelled So I think `contains(needs.*.result, 'failure') || cancelled()` should be enough.

> > Can't we use [job concurrency](https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/control-the-concurrency-of-workflows-and-jobs) for this? > > That’s what we do in this patch :) I meant using [job concurrency](https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/control-the-concurrency-of-workflows-and-jobs) for decision task (thus avoiding race...

> Do you know if it will break things like PR checks, or should we go ahead and try this approach? This could be problematic, as stuff is sometimes cancelled...