pythcoiner

Results 300 comments of pythcoiner

> I tend to disagree, why should it have a copy button? The descriptor backup step is prior to that one. it's the only place where the descriptor is displayed...

> What does the delay accomplish here? Avoid one more click I feel in the broadcast flow there is too musch click, user already click 2 times (after sign) for...

> A user should check as many characters as possible, **and not only beginning/end** agree 100% with that, but honnestly , how much char i check depends more on the...

then i restart a new chain + new wallet and generate 20 block per batch (reusing index 0-19) wallet is stuck at 9190.625 + 275 unconfirmed: ![image](https://github.com/wizardsardine/liana/assets/124568858/22484031-d14a-4279-aa6a-cf09a18f15d2) ~~looks like the...

ok more details, they are 2 different tests on 2 differents regtests, 2 differents wallets. First test: - New regtest (start at genesis) + new liana wallet - Generating 500...

the easy way is to use the `TextInput` w/o restyling it, setting a dummy message w/ `on_input()` that is not handled in `update()`, so the displayed data cannot be enabled.

cc @benma i remember your [comment](https://github.com/bitcoin/bips/pull/1458?ref=bitbox.swiss#discussion_r1337755627) on BIP-0352, can't some signing devices have some issue also here about sorting keys with complexes taptrees?

Note: @darosior had implemented a similar approach in [Liana](https://github.com/wizardsardine/liana/blob/6aed1cb450b53c7ef8ee23ccb49c10729f9ea8e0/liana/src/descriptors/analysis.rs#L398), the main difference is there is no duplicate removing & sorting. Some signing devices already implemented this approach btw: - Ledger...

> and is incompatible with BIP388 wallet policies since the public keys aren't deduplicated. This is mentioned in the rationale. I'm not sure to understand this point as iirc at...