pythcoiner

Results 300 comments of pythcoiner

i'm really not sure upgrading bdk solve our issue, the issue seems related to `rust-tls`, and the bdk client does not reexport the [ssl feature](https://github.com/bitcoindevkit/bdk/blob/2cf46a2a9e513d3f2612b7c363446fb1acf958ae/crates/electrum/Cargo.toml#L23) that seems the only actual...

hum, if it have been replaced in the mempool by the new one why, not considering it deprecated?

> Could you also please add the following change to this PR: [#1222 (comment)](https://github.com/wizardsardine/liana/pull/1222#discussion_r1740303324) > > Thanks 🙏 sure, i let this wip for now, i plan to do a...

ah, so maybe just `unimplemented()` should be fine, `instead todo()`

i thinks it's also fine to not select coins, but in this case we should display a warning "insufficient balance" instead wrong "xxx left to select"

btw it's a nit, as if we hover the error we have a good description of the issue

I guess this test can be valid at test time (it's likely this test is done right after you get the notif/request), but can be easily invalidated by a malicious...