pythcoiner

 

the advantage of ping both is i guess almost the time our user will not know what is ssl, so w/ this solution they don't have to care about.

> Do we need to warn about SSL if people are using on their local network? i think it's not easy to be sure wether we are a local network...

i close this for now, as we are not sure it's the way we want go

I've take a look at your prototype implem of Payjoin in Liana, I think we should not allow external inputs for the normal flow, instead we should add new commands/method...

Not a bug, It's the behaviour I initially intended. Rationale: the device is disconnected, it's a different case than if we have an error sending a request. When there is...

do you mind wrapping lines at ~ 100 chars? (as it was originally done)

overall LGTM  but I'm not sure it's needed for `liana` and 'liana-ui' as they are not binaries

from an internal discussion: add ``` export LIANA_VERSION=${VERSION} ``` after this [line](https://github.com/wizardsardine/liana/blob/13709aa302b2e7de0acee2e60c15adbb3ce4997c/contrib/release/release.sh#L10) then: - we do not hardcode the version - if `LIANA_VERSION` is defined the version should be of...

I finally had time to test this, the release script fails, while a normal `cargo build --release` is successful: ``` [...] error: environment variable `GIT_HASH` not defined at compile time...