zkevm-circuits
zkevm-circuits copied to clipboard
privacy-scaling-explorations
First TODO: https://github.com/privacy-scaling-explorations/zkevm-circuits/blob/f185b1276b67b730448724930b33c72a342ad96a/zkevm-circuits/src/state_circuit.rs#L340 Second TODO: https://github.com/privacy-scaling-explorations/zkevm-circuits/blob/f185b1276b67b730448724930b33c72a342ad96a/zkevm-circuits/src/state_circuit.rs#L582-L583 @z2trillion could you help us clarify the context of these TODOs? Are they still valid?
Currently in the `word-lo-hi` the `ConstraintBuilder` methods that receive address arguments use the `Word` type. Then calls look like this (where 2nd arg is the address): ```rust cb.account_access_list_write_word( tx_id.expr(), address.to_word(),...
### Describe the feature you would like Design philosophy for verifier (decider) is lower cost of verification. In PI circuit, there are few improvements mentioned in different issue. This issue...
After a debugging session I noticed that the layouter.assign_region method of a Circuit is being called 6 times. My guess is the following: - One iteration per phase (we have...
See: https://github.com/privacy-scaling-explorations/zkevm-circuits/blob/main/bus-mapping/src/operation.rs#L786-L798 Also would be good if @DreamWuGit who left this could add some extra explanations.
See https://github.com/privacy-scaling-explorations/zkevm-circuits/blob/f185b1276b67b730448724930b33c72a342ad96a/zkevm-circuits/src/evm_circuit/execution/end_block.rs#L89-L91 Investigate current execution client behavior and see if this applies and how feasible is to solve it now.
See: https://github.com/privacy-scaling-explorations/zkevm-circuits/blob/f185b1276b67b730448724930b33c72a342ad96a/bus-mapping/src/evm/opcodes/logs.rs#L360 Also, @DreamWuGit left this TODO so it's probably the person to ask when gathering more context about the issue.
### Describe the feature you would like Goals - "We should do a systematic refactor for check_rw_lookup to make the logging code easier to maintain", by cc, https://github.com/privacy-scaling-explorations/zkevm-circuits/pull/1482#pullrequestreview-1488496859 - Current...
### Describe the feature you would like Now `Hash` to `U256` is still keep in big endian, see here https://github.com/privacy-scaling-explorations/zkevm-circuits/blob/main/eth-types/src/lib.rs#L189-L193. While other value in U256 is assumed in little endian....
### Describe the feature you would like After introduce word lo/hi optimisation, now there are 2 ambiguous `Word` type. - `eth_types::Word` - `utils::word::Word` Proposed by @adria0, since `eth_types::Word` just a...