zkevm-circuits
zkevm-circuits copied to clipboard
privacy-scaling-explorations
### Describe the feature you would like This is a follow-up for #1646 and #1686. The benchmark for Bytecode circuit remains to be fixed. Possible direction for investigation. - DEGREE=26...
### What command(s) is the bug in? _No response_ ### Describe the bug ``` https://github.com/privacy-scaling-explorations/zkevm-circuits/actions/runs/7114348395/job/19368217803 thread 'root_real_prover::serial_test_tx_circuit_multiple_erc20_openzeppelin_transfers' panicked at 'called `Result::unwrap()` on an `Err` value: AssertionFailure("e(lhs, g2)·e(rhs, -s_g2) == O")',...
### Describe the feature you would like This is the step 3 of #1566 Rewriting MPT witness generator in Rust can make the integration to the circuit simpler. Challenge (Will...
The gen_blockchain_data deploys many contracts. It now has many duplication of deploy, get_block_number, blocks.insert, deployments.insert. It would be great to extract functions to prevent code duplication. https://github.com/privacy-scaling-explorations/zkevm-circuits/blob/999722fe638d14adc15fbc291c44792dd6ba07c3/integration-tests/src/bin/gen_blockchain_data.rs#L225-L244 Originally pointed out...
The painc message looks like below: > panicked at 'called `Result::unwrap()` on an `Err` value: JSONRpcError(JsonRpcClientError(SerdeJson { err: Error("invalid type: null, expected a sequence", line: 1, column: 5410), text: "{\"address\":\"0xc11....9e4\",\"accountProof\":[\"0xf902...........a503ebb\",\"nonce\":\"0x1\",\"storageHash\":\"0x5601...b421\",\"storageProof\":[{\"key\":\"0x0\",\"value\":\"0x0\",\"proof\":null}]}"...
### Describe the feature you would like We have an off-the-band discussion in a private channel. We summarize the points here. `Error::Synthesis` is a big pain point we heard from...
### Describe the feature you would like Reference [cargo-workspace-deduplicate](https://rust-lang.github.io/rfcs/2906-cargo-workspace-deduplicate.html), [workspace-package](https://doc.rust-lang.org/nightly/cargo/reference/workspaces.html#the-package-table) and [workspace-dependecies](https://doc.rust-lang.org/nightly/cargo/reference/workspaces.html#the-dependencies-table), suppose if we could add `workspace.package` and `workspace.dependencies` to root `Cargo.toml`: ``` [workspace.package] version = "0.1.0" edition =...
### Describe the feature you would like A missing piece for the zkEVM is the Transaction Receipts. The the components for implementing these are: - [Logs](https://github.com/ethereum/go-ethereum/blob/052355f5e2b1726552fdb38a94cf6ea1506caf95/core/types/log.go#L29) - [Bloom filter](https://github.com/ethereum/execution-specs/blob/master/src/ethereum/shanghai/bloom.py) -...
### What command(s) is the bug in? _No response_ ### Describe the bug 1. pre_check_ok == false should not share same branch with ErrContractAddressCollision ``` // Handle the case where...
### Describe the feature you would like To support Beacon chain withdrawals, we added `TestContext2` to support 3 generic inputs (number of accounts, number of txs and number of withdrawals)....
