zkevm-circuits icon indicating copy to clipboard operation
zkevm-circuits copied to clipboard

Refactor check_rw_lookup

Open KimiWu123 opened this issue 2 years ago • 0 comments

Describe the feature you would like

Goals

  • "We should do a systematic refactor for check_rw_lookup to make the logging code easier to maintain", by cc, https://github.com/privacy-scaling-explorations/zkevm-circuits/pull/1482#pullrequestreview-1488496859
  • Current design only supports one copy event in an assignment, we should find a more generic way to do the check https://github.com/privacy-scaling-explorations/zkevm-circuits/pull/1482#issuecomment-1600378826 and here is a draft by @hero78119

However, we're doing word lo/hi refactor and should avoid any big changes for now. Better to do this after word lo/hi merged.

Additional context

No response

KimiWu123 avatar Jun 21 '23 08:06 KimiWu123