zkevm-circuits

zkevm-circuits copied to clipboard

Proof Generation for KECCAK & SUPER circuit fails with error: RootCircuit::new: AssertionFailure("e(lhs, g2)·e(rhs, -s_g2) == O") {'error': 'RootCircuit::new: AssertionFailure("e(lhs, g2)·e(rhs, -s_g2) == O")', 'result': 'FAILED'}

7

### What command(s) is the bug in? _No response_ ### Describe the bug Proof request for block consisting of single l2 transaction (eth withddraw) Proof request options: ('{"jsonrpc":"2.0", "method":"proof", '...

AronisAt79

Integration test failed

7

### What command(s) is the bug in? cargo test --release --test circuits real_prover::serial_test_super_circuit_multiple_erc20_openzeppelin_transfers -- --nocapture 2>&1 ### Describe the bug `mock_prover` passes tests, but the following error occurs when switching...

wangtsiao

Unify tables.rs table methods into `LookupTable` trait fns.

1

Almost all of the lookup tables defined in `tables.rs` actually have the methods `construct`, `assignments`, `load`... I think we could integrate all these inside of the `LookupTable` trait. Specially after...

CPerezz

Find lowest CircuitsParams values required for Default test runs

1

We should try to get the minimum values needed so that all the tests pass with the Default `CircuitsParams` (unless the tests that instenciate the params themseleves). https://github.com/privacy-scaling-explorations/zkevm-circuits/blob/f185b1276b67b730448724930b33c72a342ad96a/bus-mapping/src/circuit_input_builder.rs#L68

CPerezz

PROPOSAL: Generate circuit stats using plaf

2

### Describe the feature you would like We could add a script that for each sub-circuit and supercircuit, would generate a plaf object and generate some stats from there, like...

leolara

Handle `is_first` and `is_last` constraint in copy_circuit

1

### Describe the bug https://github.com/privacy-scaling-explorations/zkevm-circuits/pull/1419#discussion_r1201689532, Han found that there is no constraint to enforce `is_first` to be `1` and after discussion, there is no constraint for `is_last` either. More investigating...

KimiWu123

For some time we've had discussions about fuzzying the circuits with two possible aims: - Find correctness bugs (in witness generation code / circuit constraints) - Find soundness bugs (in...

ed255

In https://github.com/privacy-scaling-explorations/zkevm-circuits/pull/484 we have the first implementation of the tx circuit. For each tx it requires (due to the signature verification): - ~205 columns - ~170k rows Things to do:...

ed255

Simplify IsZero and BatchedIsZero

2

For IsZero gadget, we defined `IsZeroConfig`, `IsZeroChip`, and `IsZeroInstruction`. For BatchedIsZero gadget, we defined BatchedIsZeroChip and BatchedIsZeroConfig. For each case, we can collect all relevant methods and keep only XConfig...

ChihChengLiang

Calculate SignVerify region number of rows at runtime

2

In https://github.com/privacy-scaling-explorations/zkevm-circuits/pull/994 we introduced methods for each circuit to report the minimum number of rows required. The SignVerify circuit uses halo2wrong, making the number of rows required opaque. The number...

ed255