Peter Conrad

Results 179 comments of Peter Conrad

Done with https://github.com/bitshares/bitshares-fc/pull/167 + https://github.com/bitshares/bitshares-fc/pull/168 , waiting for merge + fc bump

The cherry-picked changes are covered by the EOS license (MIT).

> I will add code to not connect if accept-incoming-connections is false. Please use a different flag. These should be two distinct settings. (A node operator might want to have...

Travis fails on the pr. There may be an include missing.

Node currently ignores unknown messages in the range 5000..5099, so it would be OK to rip out the code completely. This should be equivalent to making the `on_xxx_message` handlers empty....

Wrt network mapper I think the changes are ok. Don't put too much effort in it.

Careful, a mutex in a logger is dangerous for performance.

Proper procedure is 1. Write a BSIP 2. Once it's deemed complete: have it approved 3. Once it's been approved: implement (you may implement it at your own risk before...

Assigned since you're dealing with this on the ui side too. Hope that's ok with you @ryanRfox .

Related: https://github.com/EOSIO/eos/commit/b2be86055896d81fcffb88b9c992cacb3f9ddb44