Peter Conrad
Peter Conrad
As mentioned on Telegram, I'm undecided if we should merge this in the upcoming release. I generally think explicit constructors are better, because that avoids surprising automatic conversion. OTOH making...
Surprising side-effects could be avoided by changing **all** one-argument constructors to explicit. SonarQube lists 61 such issues in the core code, not counting those in fc nor test suites.
Like I said, we should make all one-arg constructors explicit in one go. But I think we have more important stuff and little time for the next release, so I'd...
See my comment above - merging this now could have unforeseeable side effects. Better to switch all one-arg constructors to `explicit` at once.
I would recommend to wait for these improvements before porting: https://github.com/bitshares/bsips/issues/163
~~Incomplete it seems.~~
I think what will be more important for API users is error messages in the `FC_ASSERT`s in lines 173 and 179. The one in 179 in particular should mention the...
Please specify more precisely what you mean with "discontinue usage". The two examples given are quite different.
I had an NPE with version 0.5.4 at the same line as in the OP, but with a different stack trace. It turned out that due to a race condition...
The cherry-picked changes are covered by the EOS license (MIT).