bitshares-core icon indicating copy to clipboard operation
bitshares-core copied to clipboard

Review and backport EOS PR 3037 log appender mutex

Open abitmore opened this issue 7 years ago • 2 comments

https://github.com/EOSIO/eos/pull/3037

abitmore avatar May 30 '18 14:05 abitmore

Careful, a mutex in a logger is dangerous for performance.

pmconrad avatar May 30 '18 16:05 pmconrad

This is why stderr and stdout are horrible for logging in multi-threaded apps. My advice is to add the mutex but document the performance penalty to discourage its use.

jmjatlanta avatar May 30 '18 16:05 jmjatlanta