Paul Connelly

Results 199 comments of Paul Connelly

Will this have any effect on the following error I always observe when running the tests locally? On linux. Usu I use `build:ci` to build them. ``` --[ FAILURE: @itwin/core-i18n...

> you just need to run `webpack:test` after building and before testing Please make sure either the `build` or the `test` script does the webpacking. `rush build:ci` followed by `rush...

> should be done in a separate one if we choose to do so Separate PR fine but don't make every dev manually run webpack:tests for this one package when...

> Should I add webpack:test to build, build:ci, or both? build:ci.

@ColinKerr got anything?

It looks like the camera is off. If the camera is on, you will wind up with an extremely wide (fish-eye) field of view in landscape mode.

Please do not add any assumptions to packages like core-frontend like "there is exactly one iModel", "there is exactly one viewport", "iModel is being opened from hub", etc.

> IModelApp.startup since it should only happen once within a session. I seem to recall the Synchro team (used to?) shut down and restart IModelApp under certain circumstances.

ImageTests shows 80 major differences against previous run. - Helsinki: definitely fixed - control points now align - Big E** point cloud. Delaware Waterfront, Redmond - vertical shift - all...