Paul Connelly
Paul Connelly
Have you checked yet to see if the dprint formatted code conflicts with any of our formatting-related lint rules? Ideally we could remove all such rules and let the formatter...
iTwin.js solves this by having a single WebGL context. The [render system](https://github.com/iTwin/itwinjs-core/blob/176dcee5813463276368319fe35e157b1b2f2b92/core/frontend/src/internal/render/webgl/System.ts#L289) object creates a HTMLCanvasElement and from it obtains the WebGL context. Each [Viewport](https://github.com/iTwin/itwinjs-core/blob/176dcee5813463276368319fe35e157b1b2f2b92/core/frontend/src/Viewport.ts#L3097) (roughly equivalent to a CesiumJS...
> Unrelated to this PR but I'm surprised that [GeometricError](https://github.com/CesiumGS/3d-tiles/blob/main/specification/README.adoc#geometric-error) is not enabled by default. Would we get a performance improvement for reality mesh as well? Yes, at the expense...
> ```ts > const url = `https://tile.googleapis.com/v1/3dtiles/root.json?key=YOUR_GOOGLE_3D_TILES_KEY_GOES_HERE`; > viewState.displayStyle.attachRealityModel({ > tilesetUrl: url, > ``` The url gets stored in the display style JSON. People will not want to store their...
> @pmconne By the way, we noticed a side effect here from your recent maximumScreenSpaceError-related PR. Previously, we set `usesGeometricError = true` for the Google 3D Tiles, but did not...
@aruniverse please revisit your comments.
If trying to delete a subclass of `Bis.DefinitionElement` is **always** supposed to be an error then the changes are fine and consolidating the checks to the base class method is...
I agree with most of @kabentley's sentiments. I think this discussion belongs on [the issue](https://github.com/iTwin/itwinjs-backlog/issues/1072), but he lacks access to it. The proposed error interface looks like this: ```ts export...
> Should team responsible for Revit Connector be contacted and ask that they bring TextureIds over as hexadecimal strings? 100%. It is never correct to store element IDs in JSON...
@khanaffan thoughts?