itwinjs-core
itwinjs-core copied to clipboard
iTwin
Bad aspect scope on remap model master backport (backport #4415)
This is a manual backport of pull request #4415
- all new public API surface in 3.5 has been made internal
- all deprecations were removed
you can use the following git command for git's version of comparing two diff ranges, to compare the backport against the original
git range-diff 93b8f6364fb..bad-aspect-scope-on-remap-model-master origin/release/3.4.x..bad-aspect-scope-on-remap-model-master-backport
@MichaelBelousov
<summaryClick to expand
<details>
...huge amount of text...
</details>
</summary>
I went through the diff and it looks correct, but I'm still waiting on local tests to complete before I mark as ready to review.
managed to unscrew bdf pulling apparently not working properly (possibly on linux)? But I am still building locally. In the interest of time I am going to let the CI start by undrafting. But if you want to hold off on reviewing until local tests have passed, wait until I leave another comment
wait CI won't work until we've merged the native half of this. ~Which we won't merge until this is approved~ so local is the only option.
confirmed locally that tests are passing. This is ready for review.
@calebmshafer @iTwin/mobilesdkadmins no space on disk again when doing a mac build: https://dev.azure.com/bentleycs/iModelTechnologies/_build/results?buildId=1737485&view=logs&j=a65881a6-3f45-5b3c-dc40-37a1baa5e3dd&t=9259c504-7cb0-5b00-8514-7fc1eebf4db8 (during pull) @chuckkir any chance you're still around to clean the disk? If not it's OK, I guess this will wait until monday then.
@calebmshafer @iTwin/mobilesdkadmins no space on disk again when doing a mac build ...
It looks like this is a different Mac from before. @chuckkir, you'll probably want to clean up all of them when you get a chance.
I purged all the macs. There were hundreds of GB on each.
We won't be able to call "npm cache clear --force" once we remove Node from all those boxes. Is it safe to just "rm -rf ~/.node" ?
got an abort during core-full-stack-tests on linux: https://dev.azure.com/bentleycs/iModelTechnologies/_build/results?buildId=1738637&view=logs&jobId=ec0cb1e7-d2ed-5545-a24f-dc432ffe481b&j=ec0cb1e7-d2ed-5545-a24f-dc432ffe481b&t=a7b95407-e870-5790-e65c-8fe4768190fd
this one was more specific:
node: tpp.c:84: __pthread_tpp_change_priority: Assertion `new_prio == -1 || (new_prio >= fifo_min_prio && new_prio <= fifo_max_prio)' failed.
Aborted (core dumped)
Returned error code: 134
"core-full-stack-tests" failed to build.
https://dev.azure.com/bentleycs/iModelTechnologies/_build/results?buildId=1738721&view=logs&jobId=ec0cb1e7-d2ed-5545-a24f-dc432ffe481b&j=ec0cb1e7-d2ed-5545-a24f-dc432ffe481b&t=a7b95407-e870-5790-e65c-8fe4768190fd are there known issues in 3.4.18?
@MichaelBelousov this has been happening for a little while. If you haven't already, file an issue for the flaky test.
@MichaelBelousov this has been happening for a little while. If you haven't already, file an issue for the flaky test.
filed it this morning as well as one for a hang/deadlock in presentation tests I also caught here where the linux agent times out