P. L. Lim

@astrofrog looks like you unleashed pre-commit in this repo, can you please have a look? Thanks!

Rebase won't hurt at this point. Wanna do that? Thanks!

I voiced concern with the implementation in Jdaviz only because I worry that Jdaviz is creating a new format with no buy-in from `regions` (or Astropy). If people disagree with...

As @keflavich pointed out above, metadata is already supported by other formats, so what value is ECSV adding to the mix?

Doh... The devdeps here is `specutils: 1.19.1.dev23+g6dcc1ad` not the RC. 🤦‍♀️ I see the same failures locally with specutils 2.0 + astropy 7.1.dev , so the compatibility problem remains.

Okay, mystery solved. devdeps here now gives the same traceback as integration testing when I switch dev specutils to install from its 2.0 branch.

Thanks to @rosteen upstream fix, unless there are more changes upstream, I think this is ready for review.

I can attempt a devdeps-cov once we are ready to proceed. I think @rosteen is still doing compat stuff over at jdaviz and I am not sure if there will...

Okay added coverage to devdeps but that job can be unstable so YMMV.

Sounds good. Thanks! I added a "todo" section in your OP above, please update as needed. I will do a general technical re-review when this PR is at final stage....