P. L. Lim

Results 1991 comments of P. L. Lim

Re: https://github.com/astropy/astropy/pull/17217#issuecomment-2428418364 I vaguely remember we also discussed performance implications, besides extra maintenance.

Do we need What's New?

Do we need What's New?

Are there actually 2 bugs then? 1. Table cannot save `np.str_` as meta. 2. Longitude returns `np.str_` instead of `str`. ❓

Can you please open a new issue for the second bug so it can be discussed separately? Thanks!

Now that you mention the radial plot, I wonder how the Gaussian1D fit would behave as well.

1. Please add a change log. 2. Please fix the test failure in devdeps job. ``` > row = cubeviz_helper.get_aperture_photometry_results()[0] E TypeError: 'NoneType' object is not subscriptable jdaviz/configs/cubeviz/plugins/tests/test_cubeviz_aperphot.py:102: TypeError ```

I still see the error in devdeps job. I suspect the photometry failed somewhere but it was swallowed by try-except block. Please run that test case manually and instead of...

~I thought we agree to disallow magnitude in aperture photometry? This is probably wrong and should not be allowed.~ (Kyle said this is now a separate ticket because we're going...

1. I don't know what the flux scaling mean in unit that isn't a variant of Jy. The original ask from user was to hardcode 3631 Jy (ref: https://en.wikipedia.org/wiki/AB_magnitude) as...