Paul Dicker

Results 308 comments of Paul Dicker
trafficstars

@jtmoon79 Thank you for the review. Sorry I am a bit slow slow with addressing your comments. I'll probably fix it up this week.

Hmm, it must be late :laughing:. I'll fix it to actually work, and merge it with the not-public `WeekDay::num_days_from` that does the same thing.

'Co-authored-by:` is new for me, I'll have to learn about that.

Thank you! It doesn't render special in Git Gui, but I guess this is it...

I just wondered: `cfg(test)` makes this method available in unit tests, but is it also available in integration tests? Yes.

I'm not going to push for this issue. Others can feel free to pick it up and/or advocate for it though.

Should get fixed with https://github.com/chronotope/chrono/pull/1083.

@djc Sorry for all the pushes. This PR and #1331 expose two more methods that can fail, that would be nice to convert to return `Result`s on 0.5. I don't...

> For example, maybe we have a `Rfc2822` wrapper for `DateTime` and this becomes a `TryFrom` impl? I have to think about this for a bit.

> So my main hesitation about this and #1331 has been that I find the `try_to_rfc2822()` method name ugly/unidiomatic. I wonder if there's something else we could do here that...