chrono icon indicating copy to clipboard operation
chrono copied to clipboard

Add `Weekday::days_since`.

Open pitdicker opened this issue 2 years ago • 2 comments
trafficstars

This resurrects the work in https://github.com/chronotope/chrono/pull/216 by @clarfonthey.

WeekDay::days_since doesn't offer any new functionality, but I quite like its API.

Fixes https://github.com/chronotope/chrono/issues/201.

pitdicker avatar Sep 02 '23 20:09 pitdicker

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 91.80%. Comparing base (0cfc405) to head (ba7ec9d).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1249   +/-   ##
=======================================
  Coverage   91.80%   91.80%           
=======================================
  Files          37       37           
  Lines       18148    18151    +3     
=======================================
+ Hits        16661    16664    +3     
  Misses       1487     1487           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Sep 02 '23 20:09 codecov[bot]

Hmm, it must be late :laughing:. I'll fix it to actually work, and merge it with the not-public WeekDay::num_days_from that does the same thing.

pitdicker avatar Sep 02 '23 21:09 pitdicker

'Co-authored-by:` is new for me, I'll have to learn about that.

pitdicker avatar Apr 06 '24 19:04 pitdicker

https://docs.github.com/en/pull-requests/committing-changes-to-your-project/creating-and-editing-commits/creating-a-commit-with-multiple-authors

djc avatar Apr 06 '24 19:04 djc

Thank you! It doesn't render special in Git Gui, but I guess this is it...

pitdicker avatar Apr 06 '24 20:04 pitdicker