Paul Dicker
Paul Dicker
The `clock` feature is already pretty much the thing that controls if `now()` and `Local` are available. If I remember right `wasm` support was quickly added to the standard library...
@ramosbugs Thank you for the good comment. For 0.5 we are not going to enable the `wasmbind` feature by default, see #1164 and #1472. Option 2 and 3 are possible...
The problem is that I also don't particularly like it, but if 80% of all the code I have to scroll through is boilerplate I have a hard time catching...
That could work. Not going to be easy; I'll look into it sometime.
I'll need a couple of comments to form an opinion. List of the constants and methods in your Rubedo crate: ```rust impl Duration { const MAX_NANOSECONDS: i64 = 9_223_372_036_854_775_807i64; const...
### Months This partly matches your work in https://github.com/chronotope/chrono/pull/1373. With `Months::new` and `Months::as_u32` we have the basic functionality to create a value and get the number back out again. Like...
### Duration > * I see a lot of value in the "full" functions for `Duration`, which provide constructors and getters for using the full range of nanoseconds and microseconds...
### NaiveDate `is_leap_year` is supported since 0.4.30: https://docs.rs/chrono/0.4.33/chrono/naive/struct.NaiveDate.html#method.leap_year. `days_in_month`, `days_in_year`, `start_of_month`, `end_of_month`, `start_of_year`, `end_of_year`: there is some overlap with this PR: https://github.com/chronotope/chrono/pull/893. Having more methods to work on dates is...
@danwilliams Some general comments. All just my personal thoughts, @djc is the primary maintainer. I only got involved around March/April, then dropped out for a couple of months, and am...