Paul Dicker

Results 308 comments of Paul Dicker
trafficstars

Closing. I would be interested to have a method to easily create a `NaiveDate` at the end of a month.

Related issue: https://github.com/chronotope/chrono/issues/528

Ok. I have started playing with this, and most of it is easy to adjust. - When parsing a `NaiveTime` seconds and nanoseconds may already be omitted. With the note...

One step further... When parsing `NaiveDateTime` it seems fine to add defaults. But when parsing a `DateTime` I would say that everything except seconds and nanoseconds need to be present....

@sinking-point I have only glanced at the code, apologies for that. The amount of lines needed for (de)serializing is massive! Is there a way to collapse that into something manageable...

I added the ability to format with [formatting parameters](https://doc.rust-lang.org/std/fmt/index.html#formatting-parameters) that can work without allocations in `no_std`. We need two adapters for `fmt::Write`. One that can count the number of characters...

Thank for the reviews :smile:. I intended this to be done. This PR and two others (maybe more are coming) are split of from my branch to add a new...

Disclaimer: Of course a lot of the performance depends on which formatting items are used. The benchmarked RFC 3339 format only uses numbers for example. So these numbers are only...

Included a commit from my WIP branch here: collect all formatting tests in the `formatting` module. So we can see a bit better which parts are covered.

Is this summary correct? The current solution in chrono is fine for most users, and avoids `localtime_r` for which we got a security advisory in the past. This PR wants...