Gregory Oschwald

Results 152 comments of Gregory Oschwald

For my use cases, decoding to a minimal struct that only has the fields I am interested in has been fast enough. Have you tried this already? It still involves...

Sorry for taking so long on this. I still need to take a closer look. One thought I have is possibly moving the decoder to another package, but I have...

Although I would accept a PR to make a more specific error type for this case, could you expand a bit on how you end up in the situation where...

I see. For what it is worth, in situations like this one, I atomically replace the reader and rely on the finalizer to eventually close the old one. If you...

Thanks. I made an example repo at https://github.com/oschwald/renovate-lfs-issue. With this repo, the exact failure is: ``` DEBUG: Error commiting files (repository=oschwald/renovate-lfs-issue, branch=renovate/js) "err": { "task": { "commands": [ "push", "origin",...

Interesting. I don't think we have changed anything on Packagist for a very long time. I can't connect to their site at the moment, but I will take a look...

The only relevant setting that I see is the "repository", which is set to "https://github.com/maxmind/GeoIP2-php". I am not sure why it is preferring the SSH in this case. This might...

You can mark the [module as deprecated in the `go.mod` file](https://go.dev/ref/mod#go-mod-file-module-deprecation). This will make `go get` print a deprecation warning.

`netip.Addr` does not make sense as the primary internal type. As mentioned, we would need to immediately convert it to a slice so that we can access the individual bits....

Is there a reason why you cannot just mock the reader via `createMock` (or, I suppose, subclass it) for testing? I am somewhat reluctant about this change as it makes...