Gregory Oschwald

Results 152 comments of Gregory Oschwald

Thanks for the idea. We may consider this in the future.

I am not sure this would be possible with the pure PHP reader. It might make sense for the extension, but we would need to figure out a reasonable way...

That does sound like a useful enhancement. Perhaps `isSiteLocalAddress` could be used. As an aside, MaxMind does not charge for failed requests.

Would you be able to expand on why this is necessary? That is a package reference to the [NuGet package](https://www.nuget.org/packages/Microsoft.Extensions.Options/5.0.0). Why do you need .NET 5.0?

There is no immediate plans on doing this. As mentioned above, it may make sense to break this package into several packages at some point, but it is unlikely to...

I don't have a strong opinion on this. This was added in #39 at the request of composer users, who indeed do not need these files normally. I'd argue that...

Would uploading a "release" tarball to GitHub with everything but `dev-bin` and the dot files (e.g., the Travis config) work for everyone? If so, we can add that to our...

Hmm, I am not sure we have one. That would be a good addition. In our own testing, we tend to test the decoder separately, e.g., [this Python test](https://github.com/maxmind/MaxMind-DB-Reader-python/blob/master/tests/decoder_test.py#L152).

This library doesn't currently support automatic reloading of the database.