Gregory Oschwald

Results 152 comments of Gregory Oschwald

> I understand that this may be upsetting, but the change introduced was, in fact, a bug fix. The problem was that your code used the bug in its favour,...

This config seems very likely to break as we add new classes. I see [GraalVM issue](https://github.com/oracle/graal/issues/1236) on wildcard support, apparently filed by users of this library. It seems unlikely that...

Thanks for the information. I think I would want a test to exist before merging this, as without it, we are unlikely to provide the kind of support that users...

This issue was fixed in [this commit](https://github.com/oschwald/maxminddb-golang/pull/159/commits/c06679525eab07f5cb7c36a8c627a7a97f21fd41) in the underlying database reader. The bug was caused by integer overflow when running on 32-bit architectures. Unless you specifically need 32-bit compatibility,...

We would also like to see this feature. It looks like Renovate used to update indirect dependencies by default, but that was removed in https://github.com/renovatebot/renovate/pull/4650. I don't fully understand the...

I believe Go just uses the Windows certificate store. It sounds likely that the administrator has up-to-date certificates in their user store and the certificates in the the local machine...

`maxmind-db` shouldn't be throwing a `NullPointerException`. That seems to be a bug there. I would have expected a `DeserializationException` with an error about `is_in_european_union` being a uint16 when a boolean...

Oh, I think this is https://github.com/maxmind/MaxMind-DB-Reader-java/issues/164. It appears the fix for that has not been released, but it is merged into main. I'll look at getting it released.

A new version of `maxmind-db` and `geoip2` were released.

If we were to add this, we would add it to all the lookup types and make the value a `netip.Prefix` rather than a string. I would probably hold off...