Gregory Oschwald
Gregory Oschwald
Although the extra dependencies do make some sense, this would likely be a breaking change for many existing web service users. I don't know if this is easily resolvable with...
I agree. This seems like something we should add.
I glanced at this and it seemed reasonable. To debug it, I'd probably start with one of the test databases and compare the output. It should be pretty straightforward to...
At a high level, this looks great! The one thing that I am not sure about is the pruning of the IPv4-mapped IPv6 networks. Although the MaxMind databases do map...
MaxMind is no longer removing the latitude and longitude from GeoLite2. See [our blog post](https://blog.maxmind.com/2018/04/11/we-are-listening-latitude-and-longitude-will-remain-in-geolite2-databases/) for more information.
We also ran into this. It is by far the most expensive thing in serving a response for our service. Unfortunately, I don't think improving the situation would be easy...
Thanks for the suggestion. We were already caching the parser. I ended up switching us to github.com/avct/uasurfer, which has much better performance.
For what it is worth, only the GeoLite _Legacy_ databases will be discontinued. The GeoLite2 databases will continue to be provided. The [geoip2 module](https://pypi.org/project/geoip2/) supports GeoLite2.
This sounds like a dupe of #51.
I don't think this issue is limited to global destruction. I frequently see the issue when the application is not otherwise exiting.