Oli Scherer comments

Results 745 comments of


                                            Oli Scherer

Test wasm32-wasip1 in CI, not wasm32-unknown-unknown

Thanks for the PR and commit splits! @bors r+ rollup=never (let's not mix CI changes with other PRs)

Add tests for the generated assembly of mask related simd instructions.

r? @workingjubilee halp, lots of SIMD stuff

Move generic `NonZero` `rustc_layout_scalar_valid_range_start` attribute to inner type.

r? @oli-obk @bors r+

Move generic `NonZero` `rustc_layout_scalar_valid_range_start` attribute to inner type.

@bors r+

Move generic `NonZero` `rustc_layout_scalar_valid_range_start` attribute to inner type.

hmm.. time traveling commits or github is confused. well bors knows about the right commit, so this should be fine ™️

Move generic `NonZero` `rustc_layout_scalar_valid_range_start` attribute to inner type.

@bors r+

Move generic `NonZero` `rustc_layout_scalar_valid_range_start` attribute to inner type.

@bors r+

Add FileCheck annotations to MIR-opt unnamed-fields tests

> Yes, for filecheck syntax. the closest we have is https://github.com/rust-lang/rust/blob/master/tests/mir-opt/README.md#filecheck-directives, which is very sparse, so if you figure out something useful, don't hesitate to add it to that file

Add FileCheck annotations to MIR-opt unnamed-fields tests

Thanks! @bors r+ rollup

Add simple async drop glue generation

Did a partial review to get an overview. I think the main comment of this PR should mention that this does not yet do > Component 2: Calling async drop...