Oli Scherer comments

Results 745 comments of


                                            Oli Scherer

Lifetime may not live enough regression

I opened PRs against all affected crates. The original reporter's crate did not show up since it was already fixed before crater started running

Verify that query keys result in unique dep nodes

@bors try @rust-timer queue

Verify that query keys result in unique dep nodes

@bors try @rust-timer queue

Only generate a ptrtoint in AtomicPtr codegen when absolutely necessary

@bors r+

Do not try to reveal hidden types when trying to prove Freeze in the defining scope

Reassigning reviewer because it allows more code on stable and needs trait system reviews

Do not try to reveal hidden types when trying to prove Freeze in the defining scope

This PR is low priority and deserves some mir_const_qualifs cleanups and reduplications before landing anyway. The other two PRs this one is based on are needed for ATPIT

Do not try to reveal hidden types when trying to prove Freeze in the defining scope

I would like to make more code compile by avoiding unnecessary (and false) query cycles in `Freeze` bound checking during const checks. Specifically, the following code snippet should compile (it...

Pass list of defineable opaque types into canonical queries

@bors try @rust-timer queue

Pass list of defineable opaque types into canonical queries

@bors try

Pass list of defineable opaque types into canonical queries

@craterbot check