Oli Scherer

Results 745 comments of Oli Scherer

The issue is that we need to check whether `FOO_CONST` doesn't contain `UnsafeCell` behind a reference. In order to do that, we need to check all constants used in the...

The change lgtm. Is it possible to design a test that is changed by this PR? It seems like an important enough edge case to warrant ensuring the generated coverage...

I'd like to land this PR first so we don't end up with it in beta. Afterwards reverting this PR again and applying a fix should not be much effort

Unilaterally accepting for beta backport. This is a soundness fix after all, and just a revert, so danger-free

@bors rollup=never this one is likely going to be conflicting a lot