rust icon indicating copy to clipboard operation
rust copied to clipboard

Add FileCheck annotations to MIR-opt unnamed-fields tests

Open Kirandevraj opened this issue 1 year ago • 7 comments

Part of #116971 Adds filecheck annotations to unnamed-fields mir-opt tests in tests/mir-opt/unnamed-fields

Kirandevraj avatar Mar 01 '24 18:03 Kirandevraj

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Mark-Simulacrum (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

rustbot avatar Mar 01 '24 18:03 rustbot

Can you share pointers/resources to improve the CHECK commands for filechecks in test cases.

Kirandevraj avatar Mar 01 '24 19:03 Kirandevraj

r? mir-opt

I don't have the knowledge to effectively review the added test conditions, though it looks reasonable enough to me.

Can you share pointers/resources to improve the CHECK commands for filechecks in test cases.

I'm not sure I understand the question. Do you mean docs on the filecheck syntax? Or something else?

Mark-Simulacrum avatar Mar 09 '24 14:03 Mark-Simulacrum

I'm not sure I understand the question. Do you mean docs on the filecheck syntax? Or something else?

Yes, for filecheck syntax.

Kirandevraj avatar Mar 09 '24 20:03 Kirandevraj

Yes, for filecheck syntax.

the closest we have is https://github.com/rust-lang/rust/blob/master/tests/mir-opt/README.md#filecheck-directives, which is very sparse, so if you figure out something useful, don't hesitate to add it to that file

oli-obk avatar Mar 11 '24 09:03 oli-obk

Thanks!

@bors r+ rollup

oli-obk avatar Mar 11 '24 22:03 oli-obk

:pushpin: Commit ba70528fd8cfbc1bf3d0b08c60dd753d6865d8a6 has been approved by oli-obk

It is now in the queue for this repository.

bors avatar Mar 11 '24 22:03 bors