Amit Kumar

Results 44 comments of Amit Kumar

Thanks Axel for review. let's wait for @TheRealMDoerr & @RealLucy comments ;-)

@TheRealMDoerr would you take final look, before I integrate it :-)

Thanks Lutz, Axel for the reviews. I did one more round of testing and things seems fine. /integrate

> with fastdebug, slowdebug and release. I think with fastdebug is sufficient.

@adinn I got one test failure on s390: `test/hotspot/jtreg/runtime/ErrorHandling/MachCodeFramesInErrorFile.java` ``` java.lang.RuntimeException: 1 < 2 at jdk.test.lib.Asserts.fail(Asserts.java:715) at MachCodeFramesInErrorFile.run(MachCodeFramesInErrorFile.java:170) at MachCodeFramesInErrorFile.main(MachCodeFramesInErrorFile.java:108) at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:104) at java.base/java.lang.reflect.Method.invoke(Method.java:565) at com.sun.javatest.regtest.agent.MainActionHelper$AgentVMRunnable.run(MainActionHelper.java:335) at java.base/java.lang.Thread.run(Thread.java:1474) ``` I...

> The System.err output in the jtr file contained [MachCode] sections for 4 compiled methods, including the two that appeared in the stack listing (crashInJava3 and crashInJava2). So, I'm not...

> That does not look right. Was there any more hserr printout after that last line? -- in particular any [MachCode]...[/MachCode] sections? It would help if you could attach the...

Please close this PR in favour of https://github.com/openjdk/jdk17u-dev/pull/2747 & enable test on your repo by going to the repo and then on actions.