jdk17u-dev icon indicating copy to clipboard operation
jdk17u-dev copied to clipboard

Backport OCSP 2836c34b64e4626e25c86a53e5bef2bf32f95d2e

Open HempushpaSahu opened this issue 1 year ago • 2 comments

Enhance OCSP, CRL and Certificate Fetch Timeouts.


Progress

  • [ ] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • [x] Change must not contain extraneous whitespace
  • [ ] Commit message must refer to an issue

Error

 ⚠️ OCA signatory status must be verified

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2754/head:pull/2754
$ git checkout pull/2754

Update a local copy of the PR:
$ git checkout pull/2754
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2754/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2754

View PR using the GUI difftool:
$ git pr show -t 2754

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2754.diff

HempushpaSahu avatar Jul 31 '24 13:07 HempushpaSahu

Hi @HempushpaSahu, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user HempushpaSahu" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

bridgekeeper[bot] avatar Jul 31 '24 13:07 bridgekeeper[bot]

❗ This change is not yet ready to be integrated. See the Progress checklist in the description for automated requirements.

openjdk[bot] avatar Jul 31 '24 13:07 openjdk[bot]

/signed

HempushpaSahu avatar Aug 05 '24 05:08 HempushpaSahu

Thank you! Please allow for up to two weeks to process your OCA, although it is usually done within one to two business days. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated!

bridgekeeper[bot] avatar Aug 05 '24 05:08 bridgekeeper[bot]

/signed

HempushpaSahu avatar Aug 16 '24 06:08 HempushpaSahu

You are already a known contributor!

bridgekeeper[bot] avatar Aug 16 '24 06:08 bridgekeeper[bot]

Backporting JDK-8179502 - Enhance OCSP, CRL and Certificate Fetch Timeouts. OCSP request throws Connection timeout occasionally, so this needs to be backported to fix the issue.

Reported issue : https://bugs.openjdk.org/browse/JDK-8179502

HempushpaSahu avatar Aug 20 '24 06:08 HempushpaSahu

Webrevs

mlbridge[bot] avatar Aug 20 '24 06:08 mlbridge[bot]

Please close this PR in favour of https://github.com/openjdk/jdk17u-dev/pull/2747 & enable test on your repo by going to the repo and then on actions.

offamitkumar avatar Aug 20 '24 08:08 offamitkumar

Duplicate of https://github.com/openjdk/jdk17u-dev/pull/2747. Hence, closing this PR Thanks.

HempushpaSahu avatar Aug 23 '24 10:08 HempushpaSahu

Hi @HempushpaSahu Oracle did not push this yet, so "Oracle parity" is to not push it. Let's see what Oracle will do...

GoeLin avatar Oct 28 '24 13:10 GoeLin

Hi @HempushpaSahu , one more thing: What happens if someone has set com.sun.security.crl.timeout and installs the update. Will that value be taken over to com.sun.security.ocsp.readtimeout, or will that fall back to 15s?

GoeLin avatar Nov 11 '24 14:11 GoeLin

Hi @HempushpaSahu , one more thing: What happens if someone has set com.sun.security.crl.timeout and installs the update. Will that value be taken over to com.sun.security.ocsp.readtimeout, or will that fall back to 15s?

This has been handled by Alexey in the openJdk PR 8179502.

HempushpaSahu avatar Nov 18 '24 07:11 HempushpaSahu