Amit Kumar
There is another problem, Build is broken with these changes. If we just pull the changes from this PR and do a build, this is the error I was getting:...
Hi @TheRealMDoerr, I added changes on top of SLP PR: https://github.com/openjdk/jdk/commit/3fd8074a52f3cc8b9c3a8e588dd352f4e6c25a76 , and faced build break with this error: ``` * For target buildtools_create_symbols_javac__the.COMPILE_CREATE_SYMBOLS_batch: # # A fatal error has...
@phohensee would you be able to take a look at this, as you reviewed the head PR as well.
>/approval request The GHA failures seems to be infrastructure-related issues. no, this is not valid reason for the approval. You need to mention "why" you want to backport this change,...
use it like this : `/approval JDK-8305906 request `
/approval request org.junit.jupiter.api is not supported. Therefore, I have added the similar annotations supported by org.junit.* @varada1110 I think instead of `editing` the comment you need to post a separate...
Hi @psawant19 , This PR doesn't make any sense if https://github.com/openjdk/jdk8u-dev/pull/480 is in review. Please close one of them.
Please merge master branch and that should trigger the GHA test again.
>/integrate @psawant19, Please go through the contribution guidelines. Don't just integrate!! There is progress check list on your PR. Once all of them are marked as `completed`. Then only you...
I guess something went wrong with GHA test. Have you turned off Github Actions ? @RealCLanger is it possible to get review from you ?