Nick Mancuso

Results 378 comments of Nick Mancuso

> and in the main block if an exception is thrown I was not aware of this nuance; this makes things a bit more complex. I can't help but wonder...

@Vyom-Yadav how do you plan to store the state of the AST/ expression as it is evaluated?

@Vyom-Yadav just to be very clear, there can be three results of expression evaluation, right? 1. Given pattern variable is in scope of block (conditional or loop) guarded/ controlled by...

We take advantage of the `expr` rule to help us build qualified names, etc; IMO, we don't ever need to analyse this "expression", therefore we don't need an EXPR parent...

We should also extend our check update docs to always consider this check when new keywords are added to the language.

@Rohanraj123 let's get existing PRs out of draft mode before opening more: https://github.com/checkstyle/checkstyle/pulls/Rohanraj123

It appears that regression happened in 8.39 release: ``` ➜ javac AnnotationArray.java ➜ cat AnnotationArray.java import java.util.List; public class AnnotationArray { @APIResponses({ // OK @APIResponse(responseCode = "200", description = "Success"),...

Trying to resolve this one: ``` file://$PROJECT_DIR$/docs/JAVA_GRAMMAR_UPDATES.md 158 project Redundant empty class Java file does not declare any class #loc @Override public DetailAstImpl visitGuardedPattern(JavaLanguageParser.GuardedPatternContext ctx) { ... JAVA 0 481...

Will we also support record patterns in switch? I do not see any examples of this.